From 6992d8def0caeb66bf5a2a579ef7686d027d4d62 Mon Sep 17 00:00:00 2001
From: SamNet-dev <sam@samnet.dev>
Date: Fri, 6 Feb 2026 15:44:29 -0600
Subject: [PATCH] fix: Prevent Telegram bot from repeating commands on file
 write failure

Use in-memory offset as primary tracker instead of relying solely on
last_update_id file. File is only read on first call for persistence
across restarts. Commands process correctly even if file is not writable.

Fixes #34
---
 conduit.sh | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/conduit.sh b/conduit.sh
index 473d09b..9fcf854 100644
--- a/conduit.sh
+++ b/conduit.sh
@@ -5298,11 +5298,15 @@ build_summary() {
 
 process_commands() {
     local offset_file="$INSTALL_DIR/traffic_stats/last_update_id"
-    local offset=0
-    [ -f "$offset_file" ] && offset=$(cat "$offset_file" 2>/dev/null)
-    offset=${offset:-0}
-    # Ensure numeric
-    [ "$offset" -eq "$offset" ] 2>/dev/null || offset=0
+    # Use in-memory offset as primary (survives file write failures)
+    # Only read from file on first call (when _CMD_OFFSET is unset)
+    if [ -z "${_CMD_OFFSET+x}" ]; then
+        _CMD_OFFSET=0
+        [ -f "$offset_file" ] && _CMD_OFFSET=$(cat "$offset_file" 2>/dev/null)
+        _CMD_OFFSET=${_CMD_OFFSET:-0}
+        [ "$_CMD_OFFSET" -eq "$_CMD_OFFSET" ] 2>/dev/null || _CMD_OFFSET=0
+    fi
+    local offset=$_CMD_OFFSET
 
     local response
     response=$(curl -s --max-time 10 --max-filesize 1048576 \
@@ -5465,7 +5469,11 @@ except Exception:
         esac
     done <<< "$parsed"
 
-    [ "$max_id" -gt "$offset" ] 2>/dev/null && echo "$max_id" > "$offset_file"
+    # Update in-memory offset first (prevents reprocessing even if file write fails)
+    if [ "$max_id" -gt "$offset" ] 2>/dev/null; then
+        _CMD_OFFSET=$max_id
+        echo "$max_id" > "$offset_file" 2>/dev/null
+    fi
 }
 
 build_report() {